Skip to content

Migrate executorch moltenVK dep (#18304)#18304

Open
ocvh wants to merge 2 commits intopytorch:mainfrom
ocvh:export-D97210565
Open

Migrate executorch moltenVK dep (#18304)#18304
ocvh wants to merge 2 commits intopytorch:mainfrom
ocvh:export-D97210565

Conversation

@ocvh
Copy link

@ocvh ocvh commented Mar 19, 2026 •
edited by meta-codesync bot
Loading

Summary:

Update moltenVK_static_unexported dependency in executorch vulkan targets.bzl to use proper path

Reviewed By: mboyd

Differential Revision: D97210565

@ocvh ocvh requested a review from SS-JIA as a code owner March 19, 2026 00:05
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 19, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18304

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c3fe57a with merge base 02bad9d (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 19, 2026

@ocvh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97210565.

@github-actions
Copy link

github-actions bot commented Mar 19, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ocvh @meta-codesync
Migrate executorch vulkan-headers dep to khronos selector
750e0ca 
Summary: Update vulkan-headers dependency in executorch vulkan targets.bzl to use the proper path

Differential Revision: D97210564
@meta-codesync meta-codesync bot changed the title Migrate executorch moltenVK dep Migrate executorch moltenVK dep (#18304) Mar 20, 2026
ocvh pushed a commit to ocvh/executorch that referenced this pull request Mar 20, 2026
@facebook-github-bot
Migrate executorch moltenVK dep (pytorch#18304)
6352db6 
Summary:

Update moltenVK_static_unexported dependency in executorch vulkan targets.bzl to use proper path

Reviewed By: mboyd

Differential Revision: D97210565
@ocvh ocvh force-pushed the export-D97210565 branch from 2f68905 to 6352db6 Compare March 20, 2026 00:36
@meta-codesync
Migrate executorch moltenVK dep (pytorch#18304)
c3fe57a 
Summary:
Pull Request resolved: pytorch#18304

Update moltenVK_static_unexported dependency in executorch vulkan targets.bzl to use proper path

Reviewed By: mboyd

Differential Revision: D97210565
@ocvh ocvh force-pushed the export-D97210565 branch from 6352db6 to c3fe57a Compare March 20, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ocvh